Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional announcement banner #243

Merged
merged 1 commit into from
Jul 26, 2024
Merged

Add optional announcement banner #243

merged 1 commit into from
Jul 26, 2024

Conversation

iansk
Copy link
Collaborator

@iansk iansk commented Jul 26, 2024

Add the ability to show an optional announcement banner at the top of any page. The banner is configurable via the metadata sheet.

In the metadata sheet, there's an announcement column. If the page being rendered has an announcement (an HTML string), the string is taken from the metadata and rendered in a red box at the top of the page.

There aren't many configuration options for announcements yet. The goal was to get this out as quickly as possible because we have old pages that customers still mistakenly reference, but which PM isn't ready to pull down yet. We want to able to quickly redirect customers to the right place.

Fix #

Test URLs:

Copy link

aem-code-sync bot commented Jul 26, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@iansk iansk requested a review from maxakuru July 26, 2024 14:10
Copy link

aem-code-sync bot commented Jul 26, 2024

Page Scores Audits Google
/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

blocks/article/article.js Show resolved Hide resolved
@iansk iansk merged commit 346c3b8 into main Jul 26, 2024
2 checks passed
@iansk iansk deleted the ian-banner branch July 26, 2024 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants